Support getting io.popen results on file:close() on PUC-Rio Lua 5.1 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamhm
force-pushed
the
io-popen-for-puc-51
branch
from
02cd465
to
e843df3
Compare
hishamhm
force-pushed
the
io-popen-for-puc-51
branch
from
e843df3
to
65254f8
Compare
|
Is there any thing in particular I should look out for when reviewing this PR? |
|
@daurnimator I followed the patterns used to load the string packing functions, and also tried to make it conditional to PUC-Rio Lua 5.1 only via ifdefs. The idea is that those changes should have no effect on other Lua versions. |
|
I've been pinged about this behavior in teal-language/tl#687 — I'm inclined to merge this and push a release if nobody else has objections. @siffiejoe? |
|
no major objections from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.