ci: add Visual C++ and MinGW jobs #315
Conversation
|
@avently Generally, please don't hijack an existing non/less-related issue/pull request. |
|
Sorry, I just wanted you to see the problem because I think you really know what you're doing based on projects you contributed to. Other issues can be unanswered for months... |
|
@diegonehab @ewestbrook Could you review this? |
|
@diegonehab @ewestbrook ping |
1 similar comment
|
@diegonehab @ewestbrook ping |
|
First of all, sorry this went so long undressed. It was unmaintained for a long time and I took over about a year ago, but we still aren't anywhere near working through the backlog of issues and even PRs. Mostly new issue activity gets things moving... Second, it looks like there is some but not necessarily 100% overlap between this and the more recent #415. @leso-kn would you be able to comment on whether there is anything here we should rescue? |
|
No problem! It seems that this is needless by #415. I close this. |
https://github.com/kou/luasocket/actions/runs/196950032 is a result of this.
MinGW job is failed because #312 isn't included. If we have #312, the job is passed: https://github.com/kou/luasocket/actions/runs/196944672
This uses Lua 5.4 for Visual C++ and Lua 5.1 for MinGW.
This has
CMakeLists.txtto build Lua 5.4 with Visual C++. It's written me from scratch because there isn't the official Lua build system for Visual C++. There are some projects that writesCMakeLists.txtsuch as https://github.com/LuaDist/lua . I searches them when I'm writing this. It seems that the official Lua will not support CMake because there is no consensus to use CMake. I searched lua-users mailing list: http://lua-users.org/cgi-bin/namazu.cgi?query=cmake+visual&idxname=lua-l&max=20&result=normal&sort=date%3AlateShould we use other
CMakeLists.txtimplementation rather than theCMakeLIsts.txtin this pull request? I think that theCMakeLists.txtin this pull request is simple enough to maintain.test/hello.luais only used for testing. We can add more tests as follow-up tasks.