adaptertest: Standardise allowed time deviations (#67)

adapters/adaptertest/recordstore.go

@@ -231,7 +231,14 @@ func testList(t *testing.T, factory func() workflow.RecordStore) {
 		}
 
 		for status, count := range config {
-			ls, err := store.List(ctx, workflowName, 0, 100, workflow.OrderTypeAscending, workflow.FilterByStatus(int64(status)))
+			ls, err := store.List(
+				ctx,
+				workflowName,
+				0,
+				100,
+				workflow.OrderTypeAscending,
+				workflow.FilterByStatus(int64(status)),
+			)
 			require.Nil(t, err)
 			require.Equal(t, count, len(ls))
 
@@ -255,15 +262,36 @@ func testList(t *testing.T, factory func() workflow.RecordStore) {
 			}
 		}
 
-		ls, err := store.List(ctx, workflowName, 0, 100, workflow.OrderTypeAscending, workflow.FilterByForeignID(foreignIDs[0]))
+		ls, err := store.List(
+			ctx,
+			workflowName,
+			0,
+			100,
+			workflow.OrderTypeAscending,
+			workflow.FilterByForeignID(foreignIDs[0]),
+		)
 		require.Nil(t, err)
 		require.Equal(t, 20, len(ls))
 
-		ls2, err := store.List(ctx, workflowName, 0, 100, workflow.OrderTypeAscending, workflow.FilterByForeignID(foreignIDs[1]))
+		ls2, err := store.List(
+			ctx,
+			workflowName,
+			0,
+			100,
+			workflow.OrderTypeAscending,
+			workflow.FilterByForeignID(foreignIDs[1]),
+		)
 		require.Nil(t, err)
 		require.Equal(t, 20, len(ls2))
 
-		ls3, err := store.List(ctx, workflowName, 0, 100, workflow.OrderTypeAscending, workflow.FilterByForeignID("random"))
+		ls3, err := store.List(
+			ctx,
+			workflowName,
+			0,
+			100,
+			workflow.OrderTypeAscending,
+			workflow.FilterByForeignID("random"),
+		)
 		require.Nil(t, err)
 		require.Equal(t, 0, len(ls3))
 	})
@@ -290,7 +318,14 @@ func testList(t *testing.T, factory func() workflow.RecordStore) {
 		}
 
 		for runState, count := range config {
-			ls, err := store.List(ctx, workflowName, 0, 100, workflow.OrderTypeAscending, workflow.FilterByRunState(runState))
+			ls, err := store.List(
+				ctx,
+				workflowName,
+				0,
+				100,
+				workflow.OrderTypeAscending,
+				workflow.FilterByRunState(runState),
+			)
 			require.Nil(t, err)
 			require.Equal(t, count, len(ls), fmt.Sprintf("Expected to have %v entries of %v", count, runState.String()))
 
@@ -319,7 +354,14 @@ func testList(t *testing.T, factory func() workflow.RecordStore) {
 		}
 
 		for status, count := range config {
-			ls, err := store.List(ctx, workflowName, 0, 100, workflow.OrderTypeAscending, workflow.FilterByStatus(int64(status)))
+			ls, err := store.List(
+				ctx,
+				workflowName,
+				0,
+				100,
+				workflow.OrderTypeAscending,
+				workflow.FilterByStatus(int64(status)),
+			)
 			require.Nil(t, err)
 			require.Equal(t, count, len(ls))
 
@@ -364,6 +406,6 @@ func recordIsEqual(t *testing.T, a, b workflow.Record) {
 	require.Equal(t, a.Status, b.Status)
 	require.Equal(t, a.Object, b.Object)
 	require.Equal(t, a.RunState, b.RunState)
-	require.WithinDuration(t, a.CreatedAt, b.CreatedAt, time.Second*10)
-	require.WithinDuration(t, a.UpdatedAt, b.UpdatedAt, time.Second*10)
+	require.WithinDuration(t, a.CreatedAt, b.CreatedAt, allowedTimeDeviation)
+	require.WithinDuration(t, a.UpdatedAt, b.UpdatedAt, allowedTimeDeviation)
 }

adapters/adaptertest/timeoutstore.go

@@ -45,7 +45,14 @@ func testCompleteAndCancelTimeout(t *testing.T, factory func() workflow.TimeoutS
 func seed(t *testing.T, store workflow.TimeoutStore, count int) {
 	ctx := context.Background()
 	for i := range count {
-		err := store.Create(ctx, "example", "andrew", fmt.Sprintf("%v", i+1), int(statusStarted), time.Now().Add(-time.Hour))
+		err := store.Create(
+			ctx,
+			"example",
+			"andrew",
+			fmt.Sprintf("%v", i+1),
+			int(statusStarted),
+			time.Now().Add(-time.Hour),
+		)
 		require.Nil(t, err)
 	}
 }
@@ -60,8 +67,8 @@ func expect(t *testing.T, count int, actual []workflow.TimeoutRecord) {
 		require.Equal(t, "andrew", timeout.ForeignID)
 		require.Equal(t, fmt.Sprintf("%v", i+1), timeout.RunID)
 		require.False(t, timeout.Completed)
-		require.WithinDuration(t, time.Now().Add(-time.Hour), timeout.ExpireAt, time.Second)
-		require.WithinDuration(t, time.Now(), timeout.CreatedAt, time.Second)
+		require.WithinDuration(t, time.Now().Add(-time.Hour), timeout.ExpireAt, allowedTimeDeviation)
+		require.WithinDuration(t, time.Now(), timeout.CreatedAt, allowedTimeDeviation)
 	}
 }
 

adapters/adaptertest/util.go

@@ -1,5 +1,9 @@
 package adaptertest
 
+import "time"
+
+const allowedTimeDeviation = time.Second * 10
+
 type status int
 
 const (