workflow: Rename Record to Run #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwormald
commented
Aug 13, 2024
andrewwormald
force-pushed
the
andreww-addSkipUtil
branch
from
9fafd5a to
9829e7f
Compare
echarrod
reviewed
Aug 14, 2024
echarrod
approved these changes
Aug 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Record has morphed and as time has gone on the idea of a workflow "run" and a workflow "Record" (different from WireRecord) have become one in the same. This MR changes the naming so that Record becomes
RunandWireRecordbecomesRecord.This cleans up the consumer interface / param where you are currently passed a Record but its more like the Run as you can control the run via the RunStateController.
The idea is that this is a breaking change prior to v1.