Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Alternative buildsystem using just instead of ant #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pprkut
Copy link
Contributor

@pprkut pprkut commented Feb 1, 2025

How to Test:

  • Install just
  • Clone the shared justfiles from https://github.com/lunr-php/justfiles
  • Configure 2 environment variables:
    • LUNR_JUSTFILES: Path to the git clone of the shared justfiles
    • LUNR_CODING_STANDARD: Path to the git clone of the lunr coding standard (if it's somewhere other than /var/www/libs/lunr-coding-standard/Lunr)

just -l shows you all the different "build targets" that are available. For example:

just phpstan
Runs phpstan with the same config as CI would

just phpstan 9
Runs phpstan with level 9 instead of the default level

just phpcs
Runs phpcs with the same config as CI would

just phpcs PSR12
Checks the code against the PSR12 coding standard

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.05%. Comparing base (b9598fe) to head (a4687d9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage     57.05%   57.05%           
  Complexity       71       71           
=========================================
  Files             5        5           
  Lines           163      163           
=========================================
  Hits             93       93           
  Misses           70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brianstoop brianstoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the phpstan and phpcs work with only these files?

justfile Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 3, 2025

@pprkut
Copy link
Contributor Author

pprkut commented Feb 3, 2025

Do the phpstan and phpcs work with only these files?

Yes. If you follow the test instructions those commands work as specified with just the files in this review 🙂
All the logic for those is in the shared justfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants