Gravity: Add space after comma to escaped list values

Reviewed at https://reviews.lunr.nl/r/939/
lunr-php · Mar 30, 2023 · 5a0dd7f · 5a0dd7f
1 parent 8e2dcd5
commit 5a0dd7f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Lunr/Gravity/Database/DatabaseQueryEscaper.php b/src/Lunr/Gravity/Database/DatabaseQueryEscaper.php
@@ -219,7 +219,7 @@ public function list_value($array_values)
             return '';
         }
 
-        return '(' . implode(',', $array_values) . ')';
+        return '(' . implode(', ', $array_values) . ')';
     }
 
     /**

diff --git a/src/Lunr/Gravity/Database/Tests/DatabaseQueryEscaperEscapeTest.php b/src/Lunr/Gravity/Database/Tests/DatabaseQueryEscaperEscapeTest.php
@@ -325,7 +325,7 @@ public function testEscapeQueryValue(): void
     public function testEscapeListValueSimpleArray(): void
     {
         $values = [ 'value1', 'value2' ];
-        $this->assertEquals('(value1,value2)', $this->class->list_value($values));
+        $this->assertEquals('(value1, value2)', $this->class->list_value($values));
     }
 
     /**

diff --git a/src/Lunr/Gravity/Database/Tests/DatabaseQueryEscaperNullEscapeTest.php b/src/Lunr/Gravity/Database/Tests/DatabaseQueryEscaperNullEscapeTest.php
@@ -49,7 +49,7 @@ public function validValueEscaperProvider(): array
         $escapers[] = [
             'list_value',
             [ 'A', 'B', 'C' ],
-            '(A,B,C)',
+            '(A, B, C)',
         ];
 
         return $escapers;
-Original file line number
+Diff line change
@@ Expand Up / @@ -219,7 +219,7 @@ public function list_value($array_values) @@
                 return '';
             }
-            return '(' . implode(',', $array_values) . ')';
+            return '(' . implode(', ', $array_values) . ')';
         }
         /**
@@ Expand Down @@