Skip to content

Commit

Permalink
Merge pull request #693 from luraproject/remove_temporal_gin_fix
Browse files Browse the repository at this point in the history
Remove gin pending fix "patch"
  • Loading branch information
kpacha authored Oct 17, 2023
2 parents bfa00c0 + ca40f6c commit 8fc9527
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions router/gin/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,6 @@ func (r ginRouter) Run(cfg config.ServiceConfig) {

r.registerEndpointsAndMiddlewares(cfg)

// TODO: remove this ugly hack once https://github.com/gin-gonic/gin/pull/2692 and
// https://github.com/gin-gonic/gin/issues/2862 are completely fixed
go r.cfg.Engine.Run("XXXX")

r.cfg.Logger.Info("[SERVICE: Gin] Listening on port:", cfg.Port)
if err := r.runServerF(r.ctx, cfg, r.cfg.Engine.Handler()); err != nil && err != http.ErrServerClosed {
r.cfg.Logger.Error(logPrefix, err.Error())
Expand Down

0 comments on commit 8fc9527

Please sign in to comment.