Skip to content

EXTENDCOMM-55 : Avoid open redirect when deleting a comment #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

EXTENDCOMM-55 : Avoid open redirect when deleting a comment #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/java/fr/paris/lutece/plugins/extend/modules/comment/web/CommentApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
import fr.paris.lutece.util.html.Paginator;
import fr.paris.lutece.util.http.SecurityUtil;
import fr.paris.lutece.util.url.UrlItem;
import java.net.MalformedURLException;


/**
Expand Down Expand Up @@ -874,7 +875,16 @@ private XPage doRemoveComment( HttpServletRequest request, String strIdExtendabl
HttpServletResponse response = LocalVariables.getResponse( );
try
{
response.sendRedirect( strFromUrl );
// Open redirect control (set baseUrl in lutece properties in case of ReverseProxy)
if ( strFromUrl.startsWith( AppPathService.getBaseUrl( request ) ) )
{
response.sendRedirect( strFromUrl );
}
else
{
AppLogService.error( "WARNING : Incorrect base URL", new MalformedURLException() );
}

}
catch (IOException e)
{
Expand Down