Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep draft 'reason' when editing own draft #490

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smichel17
Copy link
Contributor

Fixes the following bug:

  • Start editing an installer
  • Write something in the 'Reason' field
  • Save a draft

Expected: All fields stay the same
Actual: 'Reason' field gets reset to empty, so I need to re-type it before submitting

At least one person has been re-writing the reason every time they save a draft (https://discordapp.com/channels/512538904872747018/546612632027922452/721809136232431647), and I'm sure there's others who submit with blank reasons, not realizing it disappeared.

This behavior was introduced with 2ecfe2c, which was itself a bugfix for #167, so we need to take care not to reintroduce it.

This is a draft because:

  • It's kind of ugly code. I'd like to try and find a more elegant way to rearrange things.
  • I have not tested it. I'd like to get the lutris site running locally and do this.
  • Bad commit message. I'd like to clean up this PR text and include it there.

I haven't done these because I need to get to work 😆; I'll get back to this later (this weekend?), unless someone else wants to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant