Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show useful info after a "successful" search #502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show useful info after a "successful" search #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions templates/games/game_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,23 @@ <h1>Games <small>{{ paginator.count }} entries
<div class="row">
<div class="col-sm-9">
{% if games %}
<ul class="game-list">
{% for game in games %}
{% include "includes/game_preview.html" %}
{% endfor %}
</ul>
<ul class="game-list">
{% for game in games %}
{% include "includes/game_preview.html" %}
{% endfor %}
</ul>
<div class="filter-failure-message">
<p>Didn't find what you're looking for?</p>
{% if unpublished_filter %}
<p>
Feel free to <a href="{% url 'game-submit' %}">add the game</a> to our database.
</p>
{% else %}
<p>
Try looking in unpublished games.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users will be confused about this message. A better message would be: Check the ”Show unpublished” option on the filter and click ”Apply filter” to execute the search with the inclusion of unpublished games.

</p>
{% endif %}
</div>
{% else %}
<div class="filter-failure-message">
<p class="filter-failure-icon">
Expand Down