Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PaddlePaddle IR support #1400

Closed
wants to merge 28 commits into from
Closed

Add PaddlePaddle IR support #1400

wants to merge 28 commits into from

Conversation

megemini
Copy link

Hi @lutzroeder

This PR added support for PaddlePaddle IR 👉️ #1384

  • source/paddle.js added paddle.IR
  • test/models.json added test files

The validation 👉️ https://github.com/lutzroeder/netron/blob/main/CONTRIBUTING.md

  • npm run lint
  • npm test paddle

Could you please review our PR?

Thanks!

cc. @wanghuancoder @changeyoung98 @luotao1

p.s. Some graphs

https://github.com/user-attachments/files/17727144/model.json

image

https://github.com/user-attachments/files/17727103/for_net.json

image

https://github.com/user-attachments/files/17727128/if_net.json

image

Subgraph

image

@megemini
[Add] paddle pir support
a1c42f2
@megemini
[Update] paddle ir output attr
4828e44
@megemini
Merge branch 'main' of https://github.com/lutzroeder/netron into add_…
7897efe 
…paddle_ir
@megemini
[Update] update paddle.js
9c130fe
@megemini
Merge branch 'main' of https://github.com/lutzroeder/netron into add_…
69e00c0 
…paddle_ir
@megemini
[Update] update paddle.js more info
1997457
@megemini
Merge branch 'main' of https://github.com/lutzroeder/netron into add_…
7989e6d 
…paddle_ir
@megemini
[Update] add paddle ir test models
1da70e7
@megemini
[Update] refcator paddle.js
b0ad336
@megemini
[Fix] paddle.js inputs outputs
61b5110
@megemini
Merge branch 'main' of https://github.com/lutzroeder/netron into add_…
caf2d12 
…paddle_ir
@megemini
[Update] paddle.js tensor description
e349916
@megemini
[Update] paddle.js walk regions and add inputs outputs
32c2c4c
@megemini
[Update] paddle.js add more tensor info
e3d2588
@megemini
[Update] paddle.js collect regions
dc47a37
@megemini
[Update] paddle.js sub graph args' input
8ff0f0a
@megemini
[Update] paddle.js sub graph with missing inputs
d4dd91b
@megemini
Merge branch 'main' of https://github.com/lutzroeder/netron into add_…
97b9ce0 
…paddle_ir
@megemini
[Update] paddle.js shape repr
f41c94b
@megemini
[Update] paddle.js name shape repr
7409eb2
@megemini
[Update] paddle.js
81349c7
wanghuancoder
wanghuancoder approved these changes Nov 21, 2024
View reviewed changes
Copy link

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lutzroeder lutzroeder force-pushed the main branch 4 times, most recently from 3153dc7 to e66bfb5 Compare November 25, 2024 01:08
@wanghuancoder wanghuancoder mentioned this pull request Nov 25, 2024
Closed
lutzroeder
lutzroeder requested changes Nov 25, 2024
View reviewed changes
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
@megemini
Copy link
Author

Update 20241125

The description has been removed, and all attrs have been fitted into one denotation string:

image

Could you please give me more advice ~

Really thanks! :-)

@lutzroeder

@megemini megemini requested a review from lutzroeder November 25, 2024 14:26
wanghuancoder
wanghuancoder approved these changes Nov 28, 2024
View reviewed changes
Copy link

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@megemini megemini mentioned this pull request Nov 28, 2024
Closed
@lutzroeder lutzroeder force-pushed the main branch 5 times, most recently from 6c2402a to 4a32fc3 Compare November 29, 2024 19:26
lutzroeder
lutzroeder requested changes Dec 1, 2024
View reviewed changes
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
@lutzroeder lutzroeder force-pushed the main branch 2 times, most recently from 9096922 to dd64961 Compare December 1, 2024 06:45
@megemini
Copy link
Author

megemini commented Dec 1, 2024

Update 20241201

Change getPlace and getIRType with switch and case.

About paddle.IR.Region paddle.IR.OpInfo and some other classes, it might be better to keep them, what u think?

Really thanks! :-)

@lutzroeder

@megemini megemini requested a review from lutzroeder December 1, 2024 10:56
lutzroeder
lutzroeder requested changes Dec 1, 2024
View reviewed changes
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
source/paddle.js Outdated Show resolved Hide resolved
@megemini
Copy link
Author

megemini commented Dec 2, 2024

Update 20241202

  • Collapse paddle.IR, paddle.IR.GlobalInfo and paddle.IR.Program into a single paddle.IrReader class.
  • Add IR GRAPH to paddle.AttributeType, and unify switch (attr.type).
  • Make denotation shorter.
  • Put short name of op into identifier.

image

image

Really thanks! :-)

@lutzroeder

@megemini megemini requested a review from lutzroeder December 2, 2024 08:00
@wanghuancoder wanghuancoder mentioned this pull request Dec 12, 2024
Closed
@lutzroeder lutzroeder mentioned this pull request Dec 12, 2024
Closed
lutzroeder added a commit that referenced this pull request Dec 12, 2024
@lutzroeder
Add PaddlePaddle IR test files (#1400)
12ed502
@lutzroeder lutzroeder closed this Dec 12, 2024
@megemini
Copy link
Author

@lutzroeder Thanks for helping us support PaddlePaddle IR !!! 😀😀😀 👍️👍️👍️

BTW, when can https://netron.app/ be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@lutzroeder lutzroeder Awaiting requested review from lutzroeder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@megemini @lutzroeder @wanghuancoder