Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench #64

Merged
merged 14 commits into from
Jul 10, 2020
Merged

Bench #64

merged 14 commits into from
Jul 10, 2020

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

@Robinlovelace
Copy link
Collaborator Author

Heads-up @luukvdmeer and all, this PR adds some basic benchmarks to track performance. If it goes to plan, GH Actions should report benchmark runtime for every push and report results like this: https://github.com/r-lib/bench/runs/777595294?check_suite_focus=true#step:7:8

I used the https://github.com/r-lib/bench repo as a bit of a template. Hope it works, yielded interesting results already for #6.

@Robinlovelace Robinlovelace mentioned this pull request Jun 23, 2020
@luukvdmeer
Copy link
Owner

Great, thanks @Robinlovelace ! Any idea where the error message of the check is coming from? It seems to fail at line 1 already with An action could not be found at the URI 'https://api.github.com/repos/actions/checkout/tarball/develop'

@Robinlovelace
Copy link
Collaborator Author

Seems it was trying to checkout a non-existent branch. Trying with master again...

@Robinlovelace
Copy link
Collaborator Author

Heads-up @luukvdmeer it seems to be passing now 🎉

@Robinlovelace
Copy link
Collaborator Author

What do you reckon @luukvdmeer ?

@luukvdmeer
Copy link
Owner

Sorry I took sime time. Busy working life! I am happy it passes. Merged to develop.

@luukvdmeer luukvdmeer merged commit 92ed613 into develop Jul 10, 2020
@Robinlovelace
Copy link
Collaborator Author

Thanks @luukvdmeer I'm impressed and think that, assuming the st_length() calculation isn't to blame, sfnetworks seems faster than stplanr. Yet to be proven. Next step on this may be a vignette on performance.

@luukvdmeer luukvdmeer deleted the bench branch December 6, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants