-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bench #64
Bench #64
Conversation
Heads-up @luukvdmeer and all, this PR adds some basic benchmarks to track performance. If it goes to plan, GH Actions should report benchmark runtime for every push and report results like this: https://github.com/r-lib/bench/runs/777595294?check_suite_focus=true#step:7:8 I used the https://github.com/r-lib/bench repo as a bit of a template. Hope it works, yielded interesting results already for #6. |
Great, thanks @Robinlovelace ! Any idea where the error message of the check is coming from? It seems to fail at line 1 already with |
Seems it was trying to checkout a non-existent branch. Trying with |
Heads-up @luukvdmeer it seems to be passing now 🎉 |
What do you reckon @luukvdmeer ? |
Sorry I took sime time. Busy working life! I am happy it passes. Merged to develop. |
Thanks @luukvdmeer I'm impressed and think that, assuming the |
No description provided.