Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize css style with using adoptedStyleSheets #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Totati
Copy link

@Totati Totati commented Jul 18, 2023

Fixes #8

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
selectlist-polyfill ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 9:40am
selectmenu-polyfill ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 9:40am

@luwes
Copy link
Owner

luwes commented Aug 12, 2023

thanks for the contribution!

my concern on adding this is that it wouldn't work with DSD (declarative shadow DOM)
whatwg/dom#910

related project https://github.com/luwes/wesc

@Totati
Copy link
Author

Totati commented Aug 18, 2023

Hmm, why? How is this selectlist polyfill connected to DSD, do you plan to refactor the element to use DSD? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use adoptedStyleSheets instead of cloning templates
2 participants