Update parse.go #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra CRLF sequences (seen in the wild in exported Google calendar ics file)
|
Hi, thanks for your contribution! Do you have any example of ICS with this kind of problem? It could be nice to enhance the fixtures. Regards, |
luxifer
reviewed
Feb 7, 2019
| newstring = strings.Replace(newstring, "\r\n\r\n", "\r\n", -1) | ||
|
|
||
| // Return the new string | ||
| return newstring |
There was a problem hiding this comment.
could you add some fixtures to validate this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra CRLF sequences (seen in the wild in exported Google calendar ics file)