Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thai language translation #378

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Thai language translation #378

merged 2 commits into from
Oct 20, 2019

Conversation

naiiytom
Copy link
Contributor

@naiiytom naiiytom commented Oct 6, 2019 •
edited
Loading

What are you changing/introducing

Add thai language translation
some words are specific terms, so couldn't be translated

issue
luyadev/luya#1159

codeclimate[bot]
codeclimate bot reviewed Oct 6, 2019
View reviewed changes
src/messages/th/admin.php
@@ -0,0 +1,440 @@
<?php
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 15 locations. Consider refactoring.

src/messages/th/admin.php
@@ -0,0 +1,440 @@
<?php
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File admin.php has 377 lines of code (exceeds 250 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Oct 6, 2019

Code Climate has analyzed commit 167ddec and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 25.7% (0.0% change).

View more on Code Climate.

@nadar
Copy link
Contributor

nadar commented Oct 6, 2019

Thank you very much, in order to merge the admin PR, we also need a PR for core and CMS, which is "minimal" requirement for a new language.

See the quote from issue luyadev/luya#1159:

For upcoming translators, those files must at least be translated in order to get integrated into the admin interface:
Admin: https://github.com/luyadev/luya-module-admin/tree/master/src/messages
CMS Frontend: https://github.com/luyadev/luya-module-cms/tree/master/src/frontend/messages
CMS Admin: https://github.com/luyadev/luya-module-cms/tree/master/src/admin/messages

@naiiytom
Copy link
Contributor Author

naiiytom commented Oct 7, 2019

Okay, I will also do the remainings then.

@nadar
Copy link
Contributor

nadar commented Oct 8, 2019

Nice, so i will wait for the other two requests until i can merge.

@nadar
Copy link
Contributor

nadar commented Oct 10, 2019

Let me know if you need help

@naiiytom
Copy link
Contributor Author

Alright, I'm working on it.

@naiiytom naiiytom mentioned this pull request Oct 20, 2019
Merged
@nadar
Copy link
Contributor

nadar commented Oct 20, 2019

Thanks!

@nadar nadar merged commit a40bcc1 into luyadev:master Oct 20, 2019
@naiiytom naiiytom deleted the th-translation branch October 20, 2019 15:14
nadar pushed a commit that referenced this pull request Dec 19, 2019
@naiiytom @nadar
Thai language translation (#378)
12f29ac 
* partial translation of thai localization

* fully thai translation
nadar added a commit that referenced this pull request Dec 19, 2019
@nadar
sequential row (index) plugin (#384)
00f23ae 
* add basic idea

* add debug info

* Thai language translation (#378)

* partial translation of thai localization

* fully thai translation

* Update Module.php

* fix sorting, add sorting relation hint.

* concept for beforeListFind callable (#382)

* concept for beforeListFind callable

* add test

* add changelog

* Update CHANGELOG.md

* fix issue with after find values (#388)

* fix issue with after find values

* add changelog, test and className update

* not found error

* prepare for release

* Update BaseFileSystemStorageTest.php (#390)

Replaced / to DIRECTORY_SEPARATOR for passing tests on Windows

* skip if pool identifier does not exists. (#392)

* skip if pool identifier does not exists.

* add changelog and since

* fix test

* add where condition

* handle plugin objects within i18n fallback value (#398)

* handle plugin objects within i18n fallback value

* add since, update changelog

* newline...

* run in seperate process

* fix test

* add whiteliste (#402)

* add whiteliste

* update code

* add unit test

* add audience and issuer properties

* Use ngRestFind() instead (#403)

* Use ngRestFind() insstead

* add changelog

* New Tag Delete Active Window (#399)

* add test and basic concept

* add hint and form

* run in seperate

* fix test

* add success delete teste

* add error test

* attach window to model

* add delete

* improve ui view

* tests

* add translations

* Update admin.php (#405)

* Update admin.php

* Update admin.php

* Update admin.php

* add missing translations

* add opcache reset

* Use ngRestFind() for API delete action. (#406)

* ngrest find and delete

* add not found exception test

* ngrest raw input/output plugin (#407)

* add raw plugin

* add changelog and "test"

* add update to "test"

* add bootstrap tests

* remove redundant execution of queue jobs (#396)

* remove redundant execution of queue jobs (there is another in bootstrap yet)

* run queue job in bootstrap for non admin context too

* add changelog

* use model as fixture

* prepare for release

* espace aws delete hint message

* escape translation word

* Bootstrap Queue CLI Commands (#410)

* bootstrap cli command

* fix admin queue name

* use luya bootstrap method

* lock file with latest version

* Update CHANGELOG.md

* lock file

* add default option for retryable jobs

* update error message in queue log

* use error in exec event

* ensure error exists

* Disable Queue (#413)

* Update Module.php

* add changelog and fix

* Travis with php 7.4 (#416)

* Block Preview styling

* Tooltip preview fix #246

* Date plugin with custom format

* Changelog for #270

* Refactored namespace using

* Connection lost handling

* Unit test fixed close #229

* CONNECTION_ID only available in mysql

* Block Preview styling

* Tooltip preview fix #246

* travis tests with php 7.4

* clean up dist

* user friendly exception (#412)

* user friendly exception

* improve message

* add test

* change cache behavior

* Update Module.php

* fix issue with title length when large error messages appear

* use luya select for ngrest filters (#419)

* use luya select for ngrest filters

* add syntax error test

* changelog

* fix changelog

* ensure group value is rendered trough plugins (#420)

* ensure group value is rendered trough plugins

* add changelog

* lazy load certain methods (#422)

* lazy load certain methods

* add tests

* add test

* add tests

* remove unused code

* check for scalar (#423)

* check for scalar

* add test

* phpdoc

* this closes #415

* prepare for release

* typos

* active buttons fix (#424)

* active buttons fix

* Update CHANGELOG.md

* Update ConfigTest.php

* Update ConfigTest.php

* echarts update closes #428

* fix bug with color plugin, closes #426

* remove deprecated function can #429

* remove deprecated method test

* add readonly option (#430)

* add readonly option

* add test

* add missing changelog

* add docs and grouped index

* add changelog
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this pull request Dec 10, 2020
@naiiytom @slowfox089
Thai language translation (luyadev#378)
5fccc5b 
* partial translation of thai localization

* fully thai translation
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this pull request Dec 10, 2020
@nadar @slowfox089
sequential row (index) plugin (luyadev#384)
0e9318b 
* add basic idea

* add debug info

* Thai language translation (luyadev#378)

* partial translation of thai localization

* fully thai translation

* Update Module.php

* fix sorting, add sorting relation hint.

* concept for beforeListFind callable (luyadev#382)

* concept for beforeListFind callable

* add test

* add changelog

* Update CHANGELOG.md

* fix issue with after find values (luyadev#388)

* fix issue with after find values

* add changelog, test and className update

* not found error

* prepare for release

* Update BaseFileSystemStorageTest.php (luyadev#390)

Replaced / to DIRECTORY_SEPARATOR for passing tests on Windows

* skip if pool identifier does not exists. (luyadev#392)

* skip if pool identifier does not exists.

* add changelog and since

* fix test

* add where condition

* handle plugin objects within i18n fallback value (luyadev#398)

* handle plugin objects within i18n fallback value

* add since, update changelog

* newline...

* run in seperate process

* fix test

* add whiteliste (luyadev#402)

* add whiteliste

* update code

* add unit test

* add audience and issuer properties

* Use ngRestFind() instead (luyadev#403)

* Use ngRestFind() insstead

* add changelog

* New Tag Delete Active Window (luyadev#399)

* add test and basic concept

* add hint and form

* run in seperate

* fix test

* add success delete teste

* add error test

* attach window to model

* add delete

* improve ui view

* tests

* add translations

* Update admin.php (luyadev#405)

* Update admin.php

* Update admin.php

* Update admin.php

* add missing translations

* add opcache reset

* Use ngRestFind() for API delete action. (luyadev#406)

* ngrest find and delete

* add not found exception test

* ngrest raw input/output plugin (luyadev#407)

* add raw plugin

* add changelog and "test"

* add update to "test"

* add bootstrap tests

* remove redundant execution of queue jobs (luyadev#396)

* remove redundant execution of queue jobs (there is another in bootstrap yet)

* run queue job in bootstrap for non admin context too

* add changelog

* use model as fixture

* prepare for release

* espace aws delete hint message

* escape translation word

* Bootstrap Queue CLI Commands (luyadev#410)

* bootstrap cli command

* fix admin queue name

* use luya bootstrap method

* lock file with latest version

* Update CHANGELOG.md

* lock file

* add default option for retryable jobs

* update error message in queue log

* use error in exec event

* ensure error exists

* Disable Queue (luyadev#413)

* Update Module.php

* add changelog and fix

* Travis with php 7.4 (luyadev#416)

* Block Preview styling

* Tooltip preview fix luyadev#246

* Date plugin with custom format

* Changelog for luyadev#270

* Refactored namespace using

* Connection lost handling

* Unit test fixed close luyadev#229

* CONNECTION_ID only available in mysql

* Block Preview styling

* Tooltip preview fix luyadev#246

* travis tests with php 7.4

* clean up dist

* user friendly exception (luyadev#412)

* user friendly exception

* improve message

* add test

* change cache behavior

* Update Module.php

* fix issue with title length when large error messages appear

* use luya select for ngrest filters (luyadev#419)

* use luya select for ngrest filters

* add syntax error test

* changelog

* fix changelog

* ensure group value is rendered trough plugins (luyadev#420)

* ensure group value is rendered trough plugins

* add changelog

* lazy load certain methods (luyadev#422)

* lazy load certain methods

* add tests

* add test

* add tests

* remove unused code

* check for scalar (luyadev#423)

* check for scalar

* add test

* phpdoc

* this closes luyadev#415

* prepare for release

* typos

* active buttons fix (luyadev#424)

* active buttons fix

* Update CHANGELOG.md

* Update ConfigTest.php

* Update ConfigTest.php

* echarts update closes luyadev#428

* fix bug with color plugin, closes luyadev#426

* remove deprecated function can luyadev#429

* remove deprecated method test

* add readonly option (luyadev#430)

* add readonly option

* add test

* add missing changelog

* add docs and grouped index

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naiiytom @nadar