Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add argument #208

Merged
merged 2 commits into from
Dec 21, 2023
Merged

refactor: add argument #208

merged 2 commits into from
Dec 21, 2023

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Oct 20, 2023

Fix #206

@maelle maelle mentioned this pull request Oct 20, 2023
Copy link
Collaborator Author

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

R/spq_perform.R Outdated Show resolved Hide resolved
R/spq_perform.R Outdated Show resolved Hide resolved
R/spq_perform.R Outdated Show resolved Hide resolved
R/spq_perform.R Outdated Show resolved Hide resolved
R/spq_perform.R Outdated Show resolved Hide resolved
R/spq_perform.R Outdated Show resolved Hide resolved
tests/testthat/test-spq_perform.R Outdated Show resolved Hide resolved
tests/testthat/test-spq_perform.R Outdated Show resolved Hide resolved
tests/testthat/test-spq_perform.R Outdated Show resolved Hide resolved
tests/testthat/test-spq_perform.R Outdated Show resolved Hide resolved
@maelle
Copy link
Collaborator Author

maelle commented Oct 20, 2023

@lvaudor you'll have a bunch of snapshot tests to update apparently

lvaudor and others added 2 commits December 21, 2023 14:47
Update R/spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update R/spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update R/spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update R/spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update R/spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update R/spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update tests/testthat/test-spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update tests/testthat/test-spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update tests/testthat/test-spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

Update tests/testthat/test-spq_perform.R

Co-authored-by: Maëlle Salmon <[email protected]>

update tests

uncomment test
@maelle maelle merged commit 96202d9 into main Dec 21, 2023
1 of 7 checks passed
@maelle maelle deleted the new-lise-branch branch December 21, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pb with replacing prefixes
2 participants