Nema: Use NemaGFX Renderer #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2024
kisvegabor
reviewed
Oct 14, 2024
kisvegabor
reviewed
Oct 29, 2024
Co-authored-by: Gabor Kiss-Vamosi <[email protected]>
|
Nice! |
kisvegabor
reviewed
Nov 6, 2024
| */ | ||
| GPIO_InitStruct.Pin = GPIO_PIN_6; | ||
| GPIO_InitStruct.Pin = GPIO_PIN_7|GPIO_PIN_6; |
There was a problem hiding this comment.
This file should be reverted.
| @@ -49,8 +49,8 @@ void MX_RTC_Init(void) | |||
| hrtc.Init.HourFormat = RTC_HOURFORMAT_24; | |||
| hrtc.Init.AsynchPrediv = 127; | |||
| hrtc.Init.SynchPrediv = 255; | |||
| hrtc.Init.OutPut = RTC_OUTPUT_ALARMA; | |||
| hrtc.Init.OutPutRemap = RTC_OUTPUT_REMAP_NONE; | |||
| hrtc.Init.OutPut = RTC_OUTPUT_ALARMB; | |||
There was a problem hiding this comment.
This file should be reverted.
| /*Configure GPIO pin Output Level */ | ||
| HAL_GPIO_WritePin(GPIOG, USB_PWR_EN_Pin|R_CS_Pin, GPIO_PIN_RESET); | ||
|
|
||
| /*Configure GPIO pin Output Level */ | ||
| HAL_GPIO_WritePin(R_RST_GPIO_Port, R_RST_Pin, GPIO_PIN_RESET); | ||
|
|
||
| /*Configure GPIO pin : PA15 */ |
There was a problem hiding this comment.
This file should be reverted.
| hdma2d.Init.OutputOffset = 0; | ||
| hdma2d.Init.BytesSwap = DMA2D_BYTES_REGULAR; | ||
| hdma2d.Init.LineOffsetMode = DMA2D_LOM_PIXELS; | ||
| hdma2d.LayerCfg[1].InputOffset = 0; | ||
| #if LV_COLOR_DEPTH == 32 |
There was a problem hiding this comment.
Are we editing a generated file? If so, can we change this setting in an LVGL file later?
| @@ -204,6 +204,16 @@ void HAL_ADC_MspInit(ADC_HandleTypeDef* adcHandle) | |||
| if(HAL_RCC_ADC12_CLK_ENABLED==1){ | |||
| __HAL_RCC_ADC12_CLK_ENABLE(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This file should be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework to use the new NemaGFX render. Update LVGL submodule to latest.
The LVGL submodule is currently tracking my fork's PR branch. See lvgl/lvgl#7002. It will be updated to track the real repo after it gets merged.