-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision signature in About #1319
base: master
Are you sure you want to change the base?
Conversation
The issue is intlool-update doesn't support m4_esyscmd_s but does m4_esyscmd. I wanted to use the latter to avoid newlines. I guess I'll add stripping instead. |
49ff717
to
aa98369
Compare
@@ -0,0 +1,24 @@ | |||
#!/usr/bin/env sh | |||
|
|||
set -eu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this makes sense, I think if git is not available in a build system it'll make the script fail. Maybe I should remove this altogether or reverse the conditional to check for the non git case first.
Sorry for taking so long to review. I'm very unsure whether the solution would work well, as I cannot predict the build enviroment of package maintainers. They more or less rely on configure.ac to statically provide a version. And we cannot predict wether they'll build from a git checkout or using a fresh source directory (make dist). |
In case it is not from git, it reads the first line of the Instead of the static version in configure.ac it will be now in Here is a tarball produced from source using I don't think that will be an issue? |
Not very familiar with autoconf/automake but the idea should work. I've tried to keep it very simple.
Note.
.version
. The tarball will be namedliferea-v$version
if from a tag orliferea-$sha-$date
if from commit..version
file.Fixes #1258
Images
From the current HEAD git commit that does not belong to a tag:
From a checked out tag https://github.com/bbhtt/liferea/releases/tag/v1.110.819: