Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Validate using appstreamcli #1340

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Mar 1, 2024

appstream-util is deprecated since 2020 and Flathub started using the newer appstreamcli tool to validate since 2 weeks ago.

So this can be finally switched.

appstream-util is deprecated since 2020 and Flathub started using
the newer appstreamcli tool to validate since 2 weeks ago.

So this can be finally switched.
@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 1, 2024

Hey, @lwindolf do you have some brand colour in mind for the app? See https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#brand-colors

I'd also request you to consider updating the screenshots. The current sizes are a bit small for the website and the Yaru theme changed a lot. It would be nice to have a set of fresh screenshots on current GNOME / Ubuntu. I can create some if you want.

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 1, 2024

Something like this maybe:

Light (#CBCFD3):

image

Dark (#64647D):

image

@lwindolf lwindolf merged commit 0161eb1 into lwindolf:master Mar 1, 2024
1 check passed
@lwindolf
Copy link
Owner

lwindolf commented Mar 1, 2024

@bbhtt Thanks for the PR and the hint on the brand color page. Looks interesting!

About updating screenshots. If you could do a set of new ones that would be awesome. I'm too busy with my freelancer work right now I do not find enough time.

@bbhtt bbhtt deleted the appdata-validate branch March 2, 2024 02:07
@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 2, 2024

Ok sure, do you have a preference for Yaru colours or stock GNOME would work too?

@bbhtt bbhtt mentioned this pull request Mar 2, 2024
@lwindolf
Copy link
Owner

lwindolf commented Mar 2, 2024

@bbhtt No preference really.

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 2, 2024

Thanks. I posted some in #1341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants