fix: fix the title being covered #3976
Conversation
|
Hi @Allsochen, Thank you for sharing another PR! Could you please share a bit more context about this PR? I've worked a lot on #814 in the past. I couldn't find a solution. It seems that you just change the font size here, for the small size. Is this a quick-win perhaps? If you have any input on #814, i would be very interested. Thank you! |
I didn't notice the problem with #184 before, but the latest code I submitted has fixed the problem. |
Allsochen
changed the title
Allsochen
changed the title
| @@ -37,6 +41,24 @@ class ThumbnailTitleView: BaseLabel { | |||
| return .byTruncatingHead | |||
| } | |||
|
|
|||
| override func draw(_ dirtyRect: NSRect) { | |||
There was a problem hiding this comment.
Could you please share why this override is necessary? What does it change compared to the native implementation? We should probably add a comment to clarify this, so that reads can understand this change better 👍
| @@ -60,7 +82,11 @@ class ThumbnailTitleView: BaseLabel { | |||
| return ceil(textSize.width) | |||
| } | |||
|
|
|||
| static func extraLineSpacing(for fontSize: CGFloat) -> CGFloat { | |||
| return fontSize * 0.2 | |||
There was a problem hiding this comment.
I imagine that 20% margin comes from your testing? Less than 20% didn't work in your tests?
Thank you
|
I've merged parts of this. I've also reworked the titles to use NSTextField instead of NSTextView. So it's a bit different now. I think the issue shown in your screenshot should be gone now. Thank you |
fix the title being covered.
Before fixed:
After fixed:
