Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add padding for whole page so that user can edit it #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paranoidjk
Copy link

No description provided.

@lxfater
Copy link
Owner

lxfater commented Apr 3, 2023

Did you test it ? Does it work? @paranoidjk

@lxfater
Copy link
Owner

lxfater commented Apr 4, 2023

I have added a div outside of the generated code. Thank you for reminding me, and I hope you continue to contribute to the code.

@paranoidjk

@lxfater lxfater closed this Apr 4, 2023
@paranoidjk
Copy link
Author

@lxfater add a div outside is still can not select the whole result if the output html has no padding
eg, prompt for "一个订单管理表格", you will get a table, but you can not select table continue to edit it

@lxfater
Copy link
Owner

lxfater commented Apr 6, 2023

@paranoidjk Thank you for your feedback. The issue is that if the element with the ID "nlu-container" is editable by the user, the GPT-3.5 model may remove this "id" attribute, causing some bugs. The decision of whether an HTML element can be edited is determined by the heuristic algorithm "isComponent" function. You can make changes to this method internally or explore other better ways to solve this problem. As I don't have much time to work on this project, I look forward to your next contribution.

@lxfater lxfater reopened this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants