Added option for smooth scrolling to LXQt file dialog #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears only with list and compact modes. By default, smooth scrolling is enabled. The reason behind this option is that Qt may slow down item sorting when the number of items is huge and scrolling is done per pixel in list or compact mode. As a workaround, the user can disable per-pixel scrolling by disabling smooth scrolling. Closes #739 WARNING: All libfm-qt based apps should be recompiled.
|
Tested by @Chiitoo and me. I couldn't find a suspicious code line after rereading it. Merging... @stefonarch, I'll make a PR for pcmanfm-qt today and appreciate your testing it with this change before November. |
|
Only now translating I wonder if |
|
Both are correct but, more precisely, we have a single view that can be in different modes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears only with list and compact modes. By default, smooth scrolling is enabled.
The reason behind this option is that Qt may slow down item sorting when the number of items is huge and scrolling is done per pixel in list or compact mode. As a workaround, the user can disable per-pixel scrolling by disabling smooth scrolling.
Closes #739
WARNING: All libfm-qt based apps should be recompiled.