lxqtbacklight: read brightness instead of actual_brightness for raw drivers #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hch12907
commented
Jul 19, 2020
| if( in == NULL ) { | ||
| return -1; | ||
| } | ||
| char type[1024]; |
There was a problem hiding this comment.
1024 is probably overkill here, but the same value is used in lxqt_backlight_backend_get_driver() as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263
Whether this is a correct fix remains to be seen, as currently all my Linux computers I have on my hand are using
rawtype drivers, and I have nothing else to test the fix with.