Show panel when showing desktop and hide on overlap enabled #1689
Conversation
…only on overlap is enabled
| if (mHidden) | ||
| mShowDelayTimer.start(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This code may not be compatible with all WMs. It may show the panel on showing desktop but there's no guarantee that the panel is made hidden again on toggling the desktop state when there is an overlap. A WM can show desktop without changing NET::WMGeometry or NET::WMState, as KWin does.
There was a problem hiding this comment.
This code may not be compatible with all WMs.
i tested on kwin, openbox and xfwm4, all of them were showing (actually it was showing panel even without the patch, but didn't when i was reproducing the issue reported), but kwin would autohide again, added a new commit to prevent that.
There was a problem hiding this comment.
Panel is overlapped (and so, hidden) → Desktop is shown → Panel is shown (sadly, by force). So far, so good. But, with this code, there's no guarantee that Panel is hidden again after Desktop is hidden.
There was a problem hiding this comment.
What Compiz does without needing a patch:
show-desktop.mp4
Compiz removes overlapping and restores it. Another WM may neither remove nor restore it.
|
To hide all windows to see the panel, maybe this is overkill, why not show the panel on windows key down event, like i3wm status bar. see #1726 |
No, it's just to ensure the panel is shown on this specific condition, and your suggestion is unrelated to this PR. |
fixes #1644