Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main menu: implement search-on-write and improve ordering of search results #1698

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Main menu: implement search-on-write and improve ordering of search results #1698

wants to merge 5 commits into from

Commits on Jun 18, 2022

  1. Implement search-on-write option 

    Signed-off-by: Adel KARA SLIMANE <[email protected]>
    @AdelKS
    AdelKS committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    049ac7f View commit details
    Browse the repository at this point in the history

  2. Disable focus logic on the search line edit with search-on-write enabled 

    We don't need to give focus to the search line edit on hover since
it will recieve the text anyway

Signed-off-by: Adel KARA SLIMANE <[email protected]>
    @AdelKS
    AdelKS committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    1f227da View commit details
    Browse the repository at this point in the history

  3. Improve ordering of search results 

    Select first result as it's the best one so far:
smallest in text size and, in this order:
1. starts with the searched text
2. contains the searched text

Signed-off-by: Adel KARA SLIMANE <[email protected]>
    @AdelKS
    AdelKS committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    ec5f9cb View commit details
    Browse the repository at this point in the history

  4. lxqtmainmenu: add event filters to redirect text to the search line 

    addtionnaly filter the events of every qaction, mSearchView and
mSearchEdit

Signed-off-by: Adel KARA SLIMANE <[email protected]>
    @AdelKS
    AdelKS committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    7bc94a6 View commit details
    Browse the repository at this point in the history

  5. lxqtmainmenu: eventFilter: factorise code 

    Signed-off-by: Adel KARA SLIMANE <[email protected]>
    @AdelKS
    AdelKS committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    126c652 View commit details
    Browse the repository at this point in the history