WIP: Normalize and refactor signal-slot connection in Pstable #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original text:
This PR refactors the signal-slot connection in the Pstable class
It's not about old code being an old-style connection, but also about the connection not being normalized as described in https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-not-normalized.md
However, I'm worried that the signal (even after my changes) is overloaded. Crazy emits warning https://github.com/KDE/clazy/blob/master/docs/checks/README-overloaded-signal.md and although the tooltips seem to work I'm unsure if that it works as originally intended
Text after debugging:
void toolTip(QPoint where, int col); is never emitted in the entire code. I have checked with debugger, breakpoint inside the slot was never triggered, even with tooltips wherever I found them. So, the question is: what is this code