Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Normalize and refactor signal-slot connection in Pstable #424

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shlyakpavel
Copy link
Member

Original text:
This PR refactors the signal-slot connection in the Pstable class
It's not about old code being an old-style connection, but also about the connection not being normalized as described in https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-not-normalized.md
However, I'm worried that the signal (even after my changes) is overloaded. Crazy emits warning https://github.com/KDE/clazy/blob/master/docs/checks/README-overloaded-signal.md and although the tooltips seem to work I'm unsure if that it works as originally intended
Text after debugging:
void toolTip(QPoint where, int col); is never emitted in the entire code. I have checked with debugger, breakpoint inside the slot was never triggered, even with tooltips wherever I found them. So, the question is: what is this code

@tsujan
Copy link
Member

tsujan commented Mar 19, 2023

DO NOT MERGE: ....

GitHub has "Convert to draft" on the right pane ;) Please use it!

about the connection not being normalized as described in

That's about the old syntax. Please use the new syntax instead of the old one, if there is any.

EDIT: Oh, you've already done it in your draft.

@shlyakpavel
Copy link
Member Author

İ already use new syntax in this PR. However, the more I try to understand this part of code the less I really get

@shlyakpavel shlyakpavel marked this pull request as draft March 19, 2023 02:00
@shlyakpavel shlyakpavel changed the title DO NOT MERGE: Normalize and refactor signal-slot connection in Pstable WIP: Normalize and refactor signal-slot connection in Pstable Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants