Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a build with Qt 6 #1067

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Allow a build with Qt 6 #1067

merged 1 commit into from
Apr 19, 2024

Conversation

tsimonq2
Copy link
Member

WIP, since QTerminal doesn't actually display anything yet.

@yan12125
Copy link
Member

I prefer to completely move to Qt 6 and drop support for Qt 5. See discussions at lxqt/qtermwidget#468.

Marking as draft for now. Feel free to mark it as ready by yourself later.

@yan12125 yan12125 marked this pull request as draft August 20, 2023 11:20
@tsimonq2
Copy link
Member Author

Sounds good, thank you @yan12125! 😄

@epasveer
Copy link

Sorry to prod. Any update on a Qt6 release for qterminal?

Thanks.

@yan12125 yan12125 marked this pull request as ready for review March 28, 2024 04:41
@yan12125
Copy link
Member

I prefer to completely move to Qt 6 and drop support for Qt 5.

I updated this branch to include only Qt 6 support. Not tested yet, though.

Sorry to prod. Any update on a Qt6 release for qterminal?

After this branch and lxqt/qtermwidget#532 are merged, qterminal should work with Qt 6.

There is still a technical issue: pyqt support in qtermwidget gets broken during qt 6 migration (see the qtermwidget PR for more details). May need some time to investigate.

@epasveer
Copy link

qterminal should work with Qt 6.

Thanks for the update. Looking forward to trying it.

@yan12125
Copy link
Member

I noticed some of my local changes overlap with #1110. I will push my remaining changes there.

@yan12125 yan12125 merged commit 31936ae into master Apr 19, 2024
0 of 2 checks passed
@yan12125 yan12125 deleted the wip-qt6 branch April 19, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants