Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue the work from https://github.com/lxqt/qtermwidget/pull/468 #515

Closed
wants to merge 8 commits into from

Conversation

bog-dan-ro
Copy link

No description provided.

@yan12125
Copy link
Member

yan12125 commented Oct 9, 2023

As I mentioned in #468, let's drop Qt 5 support and keep Qt 6 only. Feel free to ask if there are CI errors for a Qt 6-only build.

@doug1234
Copy link
Contributor

doug1234 commented Nov 3, 2023

This feature would help me out a lot. Is it possible to help out on this effort?

@yan12125
Copy link
Member

This feature would help me out a lot. Is it possible to help out on this effort?

@doug1234 Sorry for the late reply. I plan to clean-up this pull request and drop support for Qt 5 during March. It will be great if you help on that during February or March.

@doug1234
Copy link
Contributor

This feature would help me out a lot. Is it possible to help out on this effort?

@doug1234 Sorry for the late reply. I plan to clean-up this pull request and drop support for Qt 5 during March. It will be great if you help on that during February or March.

I am still able to help @yan12125 . I have a version based on the current master that builds with qt6 (but needs testing). But I am wondering how you want to proceed. I would suggest either a whole new MR that targets master or merge this MR as into wip-qt6 and I can make a MR for that branch that removes qt5 compatibility and makes a few tweaks. What do you think?

@yan12125
Copy link
Member

Thank you very much for the help!

a whole new MR that targets master

This is better. Qt 6 support may be merged soon (before the next LXQt version), so a WIP branch is not necessary.

@yan12125 yan12125 mentioned this pull request Feb 22, 2024
@yan12125
Copy link
Member

Let's move on in #532

@yan12125 yan12125 closed this Feb 25, 2024
@doug1234 doug1234 mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants