Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require exif #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Require exif #11

wants to merge 1 commit into from

Conversation

jubalh
Copy link
Member

@jubalh jubalh commented Apr 29, 2022

I don't see where we use that in the code but without this I get:

[    4s] AutoMoc: Generating MOC compilation "SRC:/build/src/xdg-desktop-portal-lxqt_autogen/mocs_compilation.cpp"
[    4s] AutoGen: Writing the parse cache file "SRC:/build/src/CMakeFiles/xdg-desktop-portal-lxqt_autogen.dir/ParseCache.txt"
[    4s] AutoGen: Writing the settings file "SRC:/build/src/CMakeFiles/xdg-desktop-portal-lxqt_autogen.dir/AutogenUsed.txt"
[    4s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] [ 12%] Built target xdg-desktop-portal-lxqt_autogen
[    4s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] /usr/bin/make  -f src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build.make src/CMakeFiles/xdg-desktop-portal-lxqt.dir/depend
[    4s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] cd /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0 /hom↪ e/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/src /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build/sr↪ c /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build/src/CMakeFiles/xdg-desktop-portal-lxqt.dir/DependInfo.cmake
[    4s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] /usr/bin/make  -f src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build.make src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build
[    4s] make[2]: *** No rule to make target '/usr/lib64/libexif.so', needed by 'src/xdg-desktop-portal-lxqt'.  Stop.

I don't see where we use that in the code but without this I get:

```
[    4s] AutoMoc: Generating MOC compilation "SRC:/build/src/xdg-desktop-portal-lxqt_autogen/mocs_compilation.cpp"
[    4s] AutoGen: Writing the parse cache file "SRC:/build/src/CMakeFiles/xdg-desktop-portal-lxqt_autogen.dir/ParseCache.txt"
[    4s] AutoGen: Writing the settings file "SRC:/build/src/CMakeFiles/xdg-desktop-portal-lxqt_autogen.dir/AutogenUsed.txt"
[    4s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] [ 12%] Built target xdg-desktop-portal-lxqt_autogen
[    4s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] /usr/bin/make  -f src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build.make src/CMakeFiles/xdg-desktop-portal-lxqt.dir/depend
[    4s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] cd /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0 /hom↪ e/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/src /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build/sr↪ c /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build/src/CMakeFiles/xdg-desktop-portal-lxqt.dir/DependInfo.cmake
[    4s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] /usr/bin/make  -f src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build.make src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build
[    4s] make[2]: *** No rule to make target '/usr/lib64/libexif.so', needed by 'src/xdg-desktop-portal-lxqt'.  Stop.
```
@tsujan
Copy link
Member

tsujan commented Apr 29, 2022

There's no need to that. xdg-desktop-portal-lxqt depends on libfm-qt, which depends on libexif.

@jubalh
Copy link
Member Author

jubalh commented Apr 29, 2022

I used BuildRequires: pkgconfig(libfm-qt) >= 1.1.0 but only when I added libexif it built.
But if you are certain then we can close this (as I added it to the spec file). So on my side the problem is solved.

@stefonarch
Copy link
Member

libexif ;)

@tsujan
Copy link
Member

tsujan commented Apr 29, 2022

Let's wait for @palinek.

@palinek
Copy link
Collaborator

palinek commented Apr 29, 2022

Hm...then isn't something wrong with dependencies propagation from libfm-qt?

@jubalh
Copy link
Member Author

jubalh commented Apr 29, 2022

Probably that would make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants