Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for ESC13 #196

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adds support for ESC13 #196

wants to merge 4 commits into from

Conversation

sploutchy
Copy link
Contributor

@gbe
Copy link

gbe commented Nov 27, 2024

Hello,

I've got a template for which your PR returns that it is vulnerable to ESC13.

In the output of Certipy, I get the following:

[...]
Issuance Policies                   : 1.3.6.1.4.1.30579.1.1.2
Linked Groups                       :
[...]
ESC13                             : 'DOM\\Authenticated Users' can enroll, template allows client authentication and issuance policy is linked to group ['']

When reading the blog post of specterops' , I understand that the template should be marked vulnerable if there's a linked group which is not the case here. Therefore I wonder if the PR should return vulnerable this template.

@sploutchy
Copy link
Contributor Author

sploutchy commented Nov 27, 2024

Hello @gbe ,
indeed, it looks like my code makes the assumption that the msDS-OIDToGroupLink attribute is set on the OID object.
However the Microsoft documentation says this attribute is not mandatory.
I implemented the check for empty link, but did not test ;) can you retest with that template and report back?
Cheers

@gbe
Copy link

gbe commented Nov 28, 2024

Unfortunately I cannot test and confirm as I no longer have access to the Certificate Authority in question. Thanks a lot for implementing a fix (even if not tested).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants