accept tgs other than host/taget_name@domain #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you want to use a TGS with certipy it has to be with the service class HOST in the service principal name of the TGS because
anySPNis set to false ingetCredentials.But I had a scenario with a LDAP service class in my TGS and couldn't use it without modifying the code.
With this PR removing the
anySPN=falsewill allowgetCredentialsto retrieve any TGS matching the target_name@domain pattern in the cache list.Knowing the service principal name doesn't matter as long as the TGS point out to the same host it will increase certipy flexibility.