Changes that enables ICE-TCP support #1802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains changes from these PRs:
#1627
#1692
and replaces them
It enables ICE-TCP support both on BE and FE. Both previous PRs did not offer/answer with TCP and server reflex candidates correctly. In particular, they didn't contain passive/active and raddr/rport information in their candidates. For example, BE offered candidates
Both of them are not correct. The first one doesn't contain tcptype information (active/passive). Another doesn't have raddr/rport data for srflx. The same for relay candidates
Also, this PR contains the latest version of adapter.js taken from https://github.com/webrtc/adapter/blob/master/release/adapter.js. This change fixes the issue when TCP candidates were not offered by FE
These changes were verified by blocking UDP traffic using iptables and using Wireshark for making sure that media is running through TCP.
Also, these changes have been tested with libnice. However, these changes contain nicer modifications as well, but I didn't verify it
Changes in Client or Server public APIs
No changes in APIs