Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OHC Term Lists #31

Open
wants to merge 2 commits into
base: dts-v8.1-branch
Choose a base branch
from

Conversation

mikejritter
Copy link

What does this do?

  • Add term lists from CollectionSpace v8.1
  • Remove anthroassertionnames

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1650

This brings in new terms from the 8.1 release into the base-instance-vocabularies.xml for the OHC tenant.

Until there's some more work done to reduce duplication of config in CollectionSpace it seemed like we can continue updating this file for the time being because OHC has customized the entrymethod term list. When making changes to the anthro term lists in 8.1 I didn't anticipate tenants which used it as a base profile.

How should this be tested? Do these changes have associated tests?

  • Rebuild CollectionSpace
  • Check that the tenant terms.json is correct

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter built locally and ran a diff on the terms (note that the first difference is from entrymethod):

[tenants] $ diff <(jq --sort-keys . anthro-tenant.terms.json) <(jq --sort-keys . ohc-tenant.terms.json)
571,573c571,577
<       "found on doorstep": "foundondoorstep",
<       "in person": "inperson",
<       "post": "post"
---
>       "bequest": "bequest",
>       "donation": "donation",
>       "found in collections": "foundincollections",
>       "purchase": "purchase",
>       "staff collected": "staffcollected",
>       "staff curated": "staffcurated",
>       "transfer": "transfer"
887a892,898
>     },
>     "majortaxon": {
>       "extinct/fossil": "extinctfossil",
>       "fungus": "fungus",
>       "modern species": "modernspecies",
>       "rock/mineral": "rockmineral",
>       "under review": "underreview"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant