worker: remove ValueError work-around for kobo from ErrataDiffBuild task

Related: release-engineering/kobo#220 Resolves: https://gitlab.cee.redhat.com/covscan/covscan/-/issues/134
lzaoral · Aug 24, 2023 · c683ff8 · c683ff8
1 parent d22019c
commit c683ff8
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/osh/worker/tasks/task_errata_diff_build.py b/osh/worker/tasks/task_errata_diff_build.py
@@ -51,18 +51,8 @@ def run(self):
             self.hub.worker.set_scan_to_basescanning(scan_id)
             self.hub.worker.assign_task(subtask_id)
             self.hub.worker.create_sb(subtask_id)
-            try:
-                self.wait()
-            except ValueError:
-                # there is a race condition here:
-                #   File "/usr/lib/python2.6/site-packages/osh/worker/tasks/task_errata_diff_build.py", line 60, in run
-                #     self.wait()
-                #   File "/usr/lib/python2.6/site-packages/kobo/worker/task.py", line 153, in wait
-                #     self._subtask_list.remove(i)
-                # ValueError: list.remove(x): x not in list
-                #
-                # FIXME: workaround it here for now
-                pass
+
+            self.wait()
             self.hub.worker.set_scan_to_scanning(scan_id)
 
         scanning_args = self.hub.worker.get_scanning_args(scanning_session_id)