-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use colcon plugins #9
base: master
Are you sure you want to change the base?
Conversation
I think keeping the old behaviour has some benefits (no additional dependencies, easy to install stuff as you mentioned). What to you think about something like this to show both approaches? |
I think it is a good approach in theory but in practice it makes the repo a little bit more overhead when using it as a template. I wanted to look into an "ROS installation step" via build.rs but didn't do it yet. I am also waiting for colcon/colcon-cargo#22 so the plugins can be downloaded with pip rosdep. |
Hi. Just to let you know I will get back to this shortly, sorry I haven't worked on open source stuff for a while. |
No problem, there was some progress to simplify the steps to install colcon tools in the meantime. Also, installing folders is possible inside Cargo.toml, so there is no need for a build.rs script. [package.metadata.ros]
install_to_share = ["launch"] Here are some relevant links if you or anyone is interested. This will reduce the overhead of installing the additional Rust tooling to a single |
This PR removes the CMake pipeline and uses ROS Rust colcon and ament plugins instead (#8 and #4).
Release builds work with
colcon build --cargo-args --release
and cleaning a package before building withcolcon build --clean-build
.I am currently missing a simple solution for "installing" launch files. In CMake this could be done with
but I haven't found an easy way with cargo yet. How would you rate the relevance for this @m-dahl ?