soc_core:allocate correct size for ROM. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wishbone and memory allocation code for ROM validated that the CPU reset address was witin the ROM address range. This however only really worked when the cpu_reset_address was 0. A second issue was that the size of the allocated memory mapping was wrongly calculated. Signed-off-by: Kees Jongenburger <[email protected]>
keesj
commented
Feb 1, 2019
| raise ValueError( | ||
| "CPU reset address 0x{:x} is not equal to the rom start addres 0x{:x}" | ||
| .format(self.cpu_reset_address,self.mem_map["rom"])) | ||
| self.add_memory_region("rom", self.mem_map["rom"],rom_size) |
There was a problem hiding this comment.
I validated that this code now allows to map the rom section to a different address and that the code still works and believe all comments stated where resolved.
sbourdeauducq
requested changes
Feb 6, 2019
| raise ValueError( | ||
| "CPU reset address 0x{:x} is not equal to the rom start addres 0x{:x}" | ||
| .format(self.cpu_reset_address,self.mem_map["rom"])) | ||
| self.add_memory_region("rom", self.mem_map["rom"],rom_size) |
There was a problem hiding this comment.
Style issues:
!=and notnot ==- space after comma
I believe that many targets and ARTIQ in particular have a reset address within the ROM (beginning of the ROM is the FPGA bitstream), so your change will break them.
If the reset address was always the ROM start, we would not need two parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #96
The wishbone and memory allocation code for ROM validated that the CPU
reset address was witin the ROM address range. This however only really
worked when the cpu_reset_address was 0. A second issue was that the
size of the allocated memory mapping was wrongly calculated.