-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #191 - Changing deployment strategy to recreate and setting replicas to max 1 #192
Conversation
…cas to max 1 Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
@LCaparelli @bszeti the image is available at: |
OLM test may fail since they changed some bits. @Kaitou786 since you've changed that on Kogito, mind replicating the fix here as well? 🤭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @ricardozanini! I didn't find the doc section lacking, it's straightforward and clear, nothing to add on my behalf but linking the HA page from Sonatype.
I do think the logic that controls spec.replica
should be placed at a default setting method, not a validation one.
@ricardozanini just tested the release candidate and things are working as expected. Setting |
Co-authored-by: Lucas Caparelli <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
@LCaparelli can you take a final look? I've moved to |
This looks great man, thanks!
Well, we will, but it will be part of the mutating webhook, not part of the reconciliation logic. |
Fixes #191
@LCaparelli do you mind taking a look? Maybe improving the doc a little bit? I'm lacking creativity...
@bszeti I'll push an image with this fix soon, do you mind taking testing in your local environment? As soon as we review and test this PR, I'll release a new version with this fix for you.
Thanks!