-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding examples/ethernet/basic, support mros2-esp32 #27
base: main
Are you sure you want to change the base?
Conversation
``` menu "mros2-esp32 network interface" choice prompt "mros2-esp32 network interface" default MROS2_ESP32_NETIF_WIFI config MROS2_ESP32_NETIF_WIFI bool "WiFi" config MROS2_ESP32_NETIF_ETH_SPI bool "Ethernet-SPI" endchoice endmenu ``` [examples/ethernet/basic/components/ethernet_init/Kconfig.projbuild](https://github.com/espressif/esp-idf/blob/master/examples/ethernet/basic/components/ethernet_init/Kconfig.projbuild) [ethernet/basic/main/Kconfig.projbuild](https://github.com/espressif/esp-idf/blob/master/examples/ethernet/basic/main/Kconfig.projbuild)
@yamati-kz first of all, thank you so much for your awesome work!!
|
#include "wifi.h" | ||
|
||
#include "ethernet_example_main.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this code block can be modified as the below.
#ifdef CONFIG_MROS2_ESP32_NETIF_WIFI
#include "wifi.h"
#elif CONFIG_MROS2_ESP32_NETIF_ETH_SPI
#include "ethernet_example_main.h"
#else
I'm not sure this modification will work well, so I'm happy if you could check the operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takasehideki
I will conduct the verification and provide the results. Please allow me some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working without any issues, as per @takasehideki -san's suggestion.
The flow remains the same, but the names have been changed. I have written the test cases in a way that makes the case distinctions clear.
#ifdef CONFIG_MROS2_ESP32_NETIF_WIFI
#include "wifi.h"
#elif CONFIG_MROS2_ESP32_NETIF_ETHERNET
#include "example_ethernet.h"
#else /* Not use Kconfig.projbuild */
#include "wifi.h"
#endif
@takasehideki |
@takasehideki san I have placed the first version of the README in yamati-kz/mros2-esp32-eth1#1 (comment) . Would it be possible to discuss it in Japanese? |
We would like to make a proposal for Ethernet support.
Could you please delete the following file: platform/ethernet/CMakeLists.txt? I realize I was wrong.
I am merging three Kconfig.projbuild files. margefile.zip
We will copy the Kconfig.projbuild file. example ~/mros2-esp32/workspace/echoback_string/main/
Handling of the Kconfig.projbuild during Ethernet support in the mros2-esp32 project #26