Fix conditional for skipping DomDecSpecialCasesTest

We require numPmeRanksRequested ≤ numPPRanksRequested in DD. Only occurs when running the test binary manually with non-default flags.
mabraham · Sep 4, 2024 · b48a0e9 · b48a0e9
1 parent bddfe80
commit b48a0e9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/programs/mdrun/tests/domain_decomposition.cpp b/src/programs/mdrun/tests/domain_decomposition.cpp
@@ -192,8 +192,9 @@ std::optional<std::string> reasonsTestIsInvalid(MdpFlavor       mdpFlavor,
     errorReasons.appendIf(numRanks > 1 && separatePmeRankFlavor == SeparatePmeRankFlavor::None
                                   && pmeFlavor == PmeFlavor::Gpu,
                           "Cannot use GPU PME offload with multiple PME+PP ranks");
-    errorReasons.appendIf(numRanks == 2 && separatePmeRankFlavor == SeparatePmeRankFlavor::Two,
-                          "Cannot use two separate PME ranks when there are only two ranks total");
+    errorReasons.appendIf(
+            numRanks < 4 && separatePmeRankFlavor == SeparatePmeRankFlavor::Two,
+            "Cannot use two separate PME ranks when there are less than four ranks total");
     errorReasons.finishContext();
     if (errorReasons.isEmpty())
     {