-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods in powersupplies.rigol, scopes.rigol #100
Open
czee
wants to merge
3
commits into
mabuchilab:master
Choose a base branch
from
czee:add_rigol_methods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ | |
import visa | ||
from pyvisa.constants import InterfaceType | ||
import numpy as np | ||
from pint import UndefinedUnitError | ||
from pint import UndefinedUnitError, UnitRegistry | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't look like this new import is used anywhere |
||
from . import Scope | ||
from .. import VisaMixin, SCPI_Facet, Facet | ||
from ..util import visa_context | ||
|
@@ -20,8 +20,8 @@ | |
import numpy as np | ||
from struct import unpack | ||
|
||
_INST_PARAMS_ = ['visa_address'] | ||
_INST_VISA_INFO_ = { | ||
_INST_PARAMS = ['visa_address'] | ||
_INST_VISA_INFO = { | ||
'DS1000Z': ('RIGOL TECHNOLOGIES', ['DS1054Z']), | ||
} | ||
|
||
|
@@ -62,6 +62,9 @@ class RigolScope(Scope, VisaMixin): | |
A base class for Rigol Technologies Scopes | ||
""" | ||
|
||
probe1 = SCPI_Facet(':CHANnel1:PROBe', convert=float) | ||
scale1 = SCPI_Facet(':CHANnel1:SCALe', convert=float) | ||
timebase_main_scale = SCPI_Facet(':TIMebase:MAIN:SCALe', convert=float) | ||
yinc = SCPI_Facet(':WAVeform:YINCrement', convert=float) | ||
yref = SCPI_Facet(':WAVeform:YREFerence', convert=float) | ||
yorig = SCPI_Facet(':WAVeform:YORigin', convert=float) | ||
|
@@ -102,6 +105,18 @@ def beeper(self, val): | |
val = int(bool(val)) | ||
self.write('SYSTem:BEEPer %s' % OnOffState(val).name) | ||
|
||
@property | ||
def display_data(self): | ||
return self._rsrc.query_binary_values(':DISPlay:DATA? ON,OFF,PNG', datatype='B', container=bytes) | ||
|
||
@property | ||
def ppulses_min(self): | ||
return self.query(':MEASure:STATistic:ITEM? MINimum,PPULses') | ||
|
||
@property | ||
def ppulses_max(self): | ||
return self.query(':MEASure:STATistic:ITEM? MAXimum,PPULses') | ||
|
||
@property | ||
def vmax_averages(self): | ||
return self.query(':MEASure:STATistic:ITEM? AVERages,VMAX') | ||
|
@@ -118,6 +133,9 @@ def vmin_averages(self): | |
def vmin(self): | ||
return self.query(':MEASure:ITEM? VMIN') | ||
|
||
def autoscale(self): | ||
self.write(':AUToscale') | ||
|
||
def get_data(self): | ||
self.write(':WAV:SOUR CHAN1') | ||
time.sleep(1) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a typo here, units should be volts