Make the linter happy

macadmins · Nov 9, 2016 · bc219e2 · bc219e2
1 parent 0db0cf8
commit bc219e2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/facter/xcode_active_directory.rb b/lib/facter/xcode_active_directory.rb
@@ -4,12 +4,10 @@
     output = Facter::Util::Resolution.exec('/usr/bin/xcode-select -p')
     if $CHILD_STATUS.exitstatus.nonzero?
       nil
+    elsif File.exist?(output.to_s.strip)
+      output
     else
-      if File.exist?(output.to_s.strip)
-        output
-      else
-        nil
-      end
+      nil
     end
   end
 end
diff --git a/lib/facter/xcode_command_line_tools.rb b/lib/facter/xcode_command_line_tools.rb
@@ -1,7 +1,9 @@
 Facter.add(:xcode_command_line_tools) do
   confine kernel: 'Darwin'
   setcode do
-    if Facter.value(:xcode_active_directory).include? '.app'
+    if Facter.value(:xcode_active_directory).nil?
+      false
+    elsif Facter.value(:xcode_active_directory).include? '.app'
       true
     else
       false