-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
0df3d61
to
71c84c5
Compare
… minor changes The progress dialog can now be called from the MGV-Core API.
71c84c5
to
dea78a6
Compare
FYI: The "clone" dialog is now based on the central |
The ProgressWdgt is going to be used internally by ProgressDlg to represent a single activity or step.
An activity must contain at least one step to be processed. Note: There's no logging available yet.
Here's a screenshot of current state: ⭐ Note, that we now actually report the checkout progress for non-bare repositories as well. @scunz Can you please review this? The implementation is a draft of the structural concept. The dialog provides no predefined slots by itself. I.e. an "onTransferProgress(...)" slot has to be implemented outside the dialog. Progress is reported to the dialog via "setPercentage(activity, step, percentageRatio)". The single steps have no "ordered state" => When progress is reported, it will be visible. Progress update happens through a timer (default interval: 500ms), because we need to cumulate the values of each single step into the total percentage for each activity. Ding this on each "setValue" would produce an O(n^2) or even O(n^n) runtime behaviour, while the timer approach is always linear. |
In general, the concept is okay. But I can see lot of trouble ahead merging this. Mostly due to the fact that this PR isn't a clean implementation of just one thing, but it rather a) moves stuff around, b) changes the clone dialog, c) introduces the new progress concept. So, I'd suggest to do the following:
|
Damn, I knew this would happen ... This PR is in a messy state I know. However, I just pushed a new branch I need to do further cleanup here (rebasing and stuff) to separate the changes. I'll report back when it's done. |
This PR was split and is handled in #36. |
This PR is INVALID and closed. See PR's #35 and #36 instead.