Skip to content

modified mul function #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

modified mul function #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dac694b
modified mul function
Sep 28, 2016
b54d276
The tests for the mul function
Sep 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion calc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ def div(a, b):
return a

def mul(a, b):
return b
"""
Copy link
Contributor

@stefanv stefanv Sep 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation

Returns the product of A and B
"""
return a * b
Copy link
Contributor

@stefanv stefanv Sep 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this functionality.


def mod(a, b):
res = a % b
Expand Down
6 changes: 5 additions & 1 deletion calc/tests/test_calc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
from calc import add
from calc import add, mul

def test_add():
assert add(1, 2) == 3

def test_mul():
assert mul(2, -3) == -6
Copy link
Contributor

@stefanv stefanv Sep 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also incorrectly indented