Fixed mod function #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanv
reviewed
Sep 28, 2016
calc/__init__.py
Outdated
| def mod(a, b): | ||
| res = a % b | ||
| return -1 | ||
| """Return the mod of 2 integers""" |
There was a problem hiding this comment.
This indentation is incorrect (should be 4 spaces)
stefanv
reviewed
Sep 28, 2016
calc/tests/test_calc.py
Outdated
| assert add(1, 2) == 3 | ||
|
|
||
| def test_mod(): | ||
| assert mod(5,2) == 1 |
|
Please rebase on master |
wilson1yan
force-pushed
the
update_mod
branch
from
0af23aa to
0893b57
Compare
stefanv
reviewed
Sep 29, 2016
| assert pow(4,0.5) == 2 | ||
|
|
||
| def test_mod(): | ||
| assert mod(5,2) == 1 |
There was a problem hiding this comment.
Incorrect indentation.
Please ensure editor is set to indent with 4 spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the mod(a,b) function implementation