Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept an interface instead of *http.Client in WithHTTPClient #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Accept an interface instead of *http.Client in WithHTTPClient #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions graphql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import (
// Client is a client for interacting with a GraphQL API.
type Client struct {
endpoint string
httpClient *http.Client
httpClient HTTPClient
useMultipartForm bool

// closeReq will close the request body immediately allowing for reuse of client
Expand Down Expand Up @@ -221,10 +221,14 @@ func (c *Client) runWithPostFields(ctx context.Context, req *Request, resp inter
return nil
}

type HTTPClient interface {
Do(*http.Request) (*http.Response, error)
}

// WithHTTPClient specifies the underlying http.Client to use when
// making requests.
// NewClient(endpoint, WithHTTPClient(specificHTTPClient))
func WithHTTPClient(httpclient *http.Client) ClientOption {
func WithHTTPClient(httpclient HTTPClient) ClientOption {
return func(client *Client) {
client.httpClient = httpclient
}
Expand Down