Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added admonition support for google docstrings #286

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

epinzur
Copy link
Contributor

@epinzur epinzur commented Oct 4, 2023

fixes #285

@machow
Copy link
Owner

machow commented Oct 5, 2023

Thanks for flagging, and submitting this PR! I'll pick up quartodoc stuff tomorrow and take a look, but wanted to leave myself a link to this google style docstring page :)

https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html

@machow
Copy link
Owner

machow commented Oct 20, 2023

LGTM, thanks for this PR!

@machow machow merged commit c4cbbea into machow:main Oct 20, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocstringSectionAdmonition is unsupported
2 participants