Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve external alias members via loading #300

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

machow
Copy link
Owner

@machow machow commented Oct 20, 2023

This PR adds support for importing functions from other packages as members.

Previously, when documenting an entire module -- if a function was directly imported from another package into a module of interest, then it worked. However, if the import was indirect, it would fail.

I also made the following tweaks:

  • respect __all__ when getting the initial module members (these may still be filtered based on options like include_attributes)
  • don't always rule out members when they're from external packages

@machow machow merged commit 0205d17 into main Oct 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant