chore: bump griffe to >=0.33, <=0.38 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This commit may break renderers implemented by downstream users if they use the `griffe.expressions` module. Over the past 8 months (and about 10 releases), griffe has had 2 releases that have broken quartodoc. So the griffe requirement is set to include only the current known working versions.
|
griffe has moved quite along and has had some nice improvements. e.g. |
|
Thanks so much for looking into this, and submitting the PR. I'm going to try migrating py-shiny's custom renderer quickly, to get a feel for griffe's new expression API, and then will merge! |
|
I hope it's okay--I removed the upper bound on griffe. If they release any more breaking changes, happy to pin an upper bound (and also open to rethinking my approach to upper bounds 😅) will merge once tests finish! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This commit may break renderers implemented by
downstream users if they use the
griffe.expressionsmodule.Over the past 8 months (and about 10 releases), griffe has had
2 releases that have broken quartodoc. So the griffe requirement
is set to include only the current known working versions.