fix: get_object dynamic supports methods set by assignments #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for dynamically documenting methods defined like...
I refactored the approach we use to look for the canonical path to an object. Previously, it wasn't always finding where the dynamic objects lived, and so resulted in returning something closer to the static result. This means that in the above case it believed some_method was an attribute.
I moved the logic for looking for where an object lives into
_canonical_path
, so hopefully it is easier to add and test new cases.