-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: initial description-list support; render_header cleanup #325
Conversation
fa74b61
to
d0e47bc
Compare
rebased against main |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 88.49% 88.46% -0.03%
==========================================
Files 37 37
Lines 2843 2931 +88
==========================================
+ Hits 2516 2593 +77
- Misses 327 338 +11 ☔ View full report in Codecov by Sentry. |
This is mostly complete, but we need to figure out how users will include the necessary css (e.g. could educate or orchestrate). |
It seems like for css, we could provide an extension that includes the necessary css via quarto's lua If we do this, we should make obvious people how to escape hatch by copying the css file into their own project. |
This PR implements description lists, based on the way py-shiny and plotnine extended the renderer in their docs.
While in the Renderer, I'll work on...
quartodoc.pandoc
submodule.Backwards incompatible changes:
render(self, dc.Object | dc.Alias)
now callsrender(self, dc.Docstring)
, rather than iterating over the docstring itself.HTML overview
Here's a rough sketch of the HTML structure rendered by quarto, using PUG:
TODO: